Conversation
mapitman
commented
Dec 21, 2025
mapitman
commented
- Remove Omarchy distribution support (directory was already deleted)
- Remove generic/github-add-key script and references (SSH keys handled during auth)
- Remove generic/lazyvim script (already deleted, cleaning up references)
- Fix scripts/check.sh to exclude markdown files from bash syntax checks
- Update copilot-instructions.md to reflect current state and resolved issues
- Remove Omarchy distribution support (directory was already deleted) - Remove generic/github-add-key script and references (SSH keys handled during auth) - Remove generic/lazyvim script (already deleted, cleaning up references) - Fix scripts/check.sh to exclude markdown files from bash syntax checks - Update copilot-instructions.md to reflect current state and resolved issues
There was a problem hiding this comment.
Pull request overview
This PR cleans up the repository by removing support for obsolete components and fixing validation scripts. It removes the Omarchy distribution support (directory already deleted), deletes the generic/lazyvim script and its references, removes the generic/github-add-key script and references (as SSH key management is now handled during GitHub authentication), and updates the check.sh script to properly exclude markdown files from bash syntax validation.
Key Changes
- Removed Omarchy distribution detection from the main bootstrap script
- Cleaned up lazyvim, github-add-key, and Starship installation references from distribution bootstrap scripts
- Fixed scripts/check.sh to exclude markdown files from bash syntax checks
- Updated copilot-instructions.md with comprehensive testing documentation and current repository state
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| bootstrap | Removes Omarchy distribution detection logic |
| ubuntu/bootstrap | Removes lazyvim, Starship, and GitHub SSH key management references |
| pop_os/bootstrap | Removes lazyvim and github-add-key references while keeping GitHub auth flow |
| fedora/bootstrap | Removes lazyvim and github-add-key references while keeping GitHub auth flow (fixes "GitHaub" typo) |
| generic/lazyvim | Deletes the lazyvim installation script |
| scripts/check.sh | Adds markdown file exclusion to bash script discovery |
| .github/copilot-instructions.md | Comprehensive documentation update reflecting current state, removed components, and expanded testing guidance |
Comments suppressed due to low confidence (1)
ubuntu/bootstrap:25
- The removal of Starship installation (curl -sS https://starship.rs/install.sh | sh) was not mentioned in the PR description, which only lists removal of lazyvim and github-add-key references. Please confirm this removal is intentional, or update the PR description to reflect this change.
# Dev packages
read -p "Install development tools? " -n 1 -r
echo
if [[ $REPLY =~ ^[Yy]$ ]]
|
|
||
| # Authenticate to GitHub | ||
| source <(curl -fsSL https://raw.githubusercontent.com/mapitman/linux-bootstrap/main/generic/github-auth-login) | ||
|
|
||
| # Add ssh key to GitHaub | ||
| source <(curl -fsSL https://raw.githubusercontent.com/mapitman/linux-bootstrap/main/generic/github-add-key) | ||
|
|
||
| # Logout of GitHub | ||
| source <(curl -fsSL https://raw.githubusercontent.com/mapitman/linux-bootstrap/main/generic/github-auth-logout) | ||
| fi |
There was a problem hiding this comment.
Inconsistency detected: ubuntu/bootstrap no longer includes github-auth-login/logout calls after this PR, but pop_os/bootstrap and fedora/bootstrap still retain these calls. This creates divergent behavior across distributions. Either ubuntu/bootstrap should keep the github-auth-login/logout pattern (like the other distros), or the other distros should also remove them for consistency.
1 participant
